feat: allow global/database IDs in Term connection where args ID inputs #2524
Merged
jasonbahl merged 8 commits intowp-graphql:developfrom Sep 19, 2022
Merged
Conversation
| * | ||
| * @return array | ||
| */ | ||
| public function get_args() { |
There was a problem hiding this comment.
Function get_args has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
9 tasks
|
Code Climate has analyzed commit d3a7a15 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jasonbahl
approved these changes
Sep 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR allows Term connection where args with a type ID to accept either global IDs or database IDs.
It also deprecates the
termTaxonomIdwhere arg, in favor of the correctly-spelledtermTaxonomyId.This PR replaces #2340 , and requires #2521 to be merged as a prerequisite.
Does this close any currently open issues?
Part of #998
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
Did not backfill tests for
cacheDomain,padCounts, andupdateTermMetaCache. I'm not entirely sure the effects of these nor how to test if the where arg has any effect on the query results.No code has changed regarding the handling of those args, so they're not technically required for this PR to merge.
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + PHP 8.0.19)
WordPress Version: 6.0.2