fix: #1687 fix node resolver when page for posts is set#2464
Merged
jasonbahl merged 2 commits intowp-graphql:developfrom Aug 4, 2022
Merged
Conversation
…ts ID matches the page being resolved
|
Code Climate has analyzed commit 29e8075 and detected 0 issues on this pull request. View more on Code Climate. |
justlevine
approved these changes
Aug 4, 2022
Collaborator
justlevine
left a comment
There was a problem hiding this comment.
tested locally with a site_url that isn't localhost, just to be safe.
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where the incorrect Type is returned when a page is set as the "page_for_posts" value.
Does this close any currently open issues?
closes #1687
Any other comments?
When a Page is set as the "page_for_posts" setting under Reading Settings:
Querying the path for that page should return a
ContentTypeand not thePageMuch like visiting the path in the browser returns the "blog" archive with the posts, instead of a static page:
If the reading settings do not have a
page_for_postssetThen a
Pagetype should be returned:Much like you would see when visiting the WordPress rendered URL: