Bug/#2409 menu item locations conflicts with taxonomy location#2411
Merged
jasonbahl merged 7 commits intowp-graphql:developfrom Jun 21, 2022
Conversation
…ing when a taxonomy is named location
… a taxonomy named location exists
…raphql#2409-menu-item-locations-conflicts-with-taxonomy-location
|
Code Climate has analyzed commit 42ef8fd and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This unsets the "location" query arg after mapping it to the WP_Query query args.
This allows the "location" arg to be used to filter by menu location but doesn't leak into WP_Query as a
location => $valueargument on the query, which would be treated as a tax query filter.Does this close any currently open issues?
closes #2409
Any other comments?
If you have a taxonomy named "location", like so:
and a menu assigned to a location, like so:
Querying for the menu items filtered by location should return the menu items
BEFORE
No menu items are returned
AFTER
Menu items are returned as expected