(bugfix): #2381 register field to setting group not working#2382
Merged
jasonbahl merged 4 commits intowp-graphql:developfrom May 16, 2022
Merged
Conversation
…otQuery type properly adds the field to the schema, but breaks when registering a field to a SettingGroup type
…ered. - update setting group to use register_graphql_object_type instead of $type_registry->register_object_type
…t registered." This reverts commit 3eda281.
…p was not registered."" This reverts commit 3caf65b.
|
Code Climate has analyzed commit 1e060c2 and detected 0 issues on this pull request. View more on Code Climate. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where fields could not be registered to GraphQL Types that are added to the Schema from the register_settings API.
Does this close any currently open issues?
closes #2381
Pushed it up with a failing test: https://github.com/wp-graphql/wp-graphql/runs/6459066904?check_suite_focus=true#step:9:463
Then the code that gets the tests to all pass: https://github.com/wp-graphql/wp-graphql/runs/6459071170?check_suite_focus=true#step:9:462