Skip to content

(bugfix): #2377 - fixes bug where Wp class wasn't being properly passed as reference to parse_request filter#2380

Merged
jasonbahl merged 1 commit intowp-graphql:developfrom
jasonbahl:bugfix/#2377-pass-wp-as-reference
May 16, 2022
Merged

(bugfix): #2377 - fixes bug where Wp class wasn't being properly passed as reference to parse_request filter#2380
jasonbahl merged 1 commit intowp-graphql:developfrom
jasonbahl:bugfix/#2377-pass-wp-as-reference

Conversation

@jasonbahl
Copy link
Copy Markdown
Collaborator

What does this implement/fix? Explain your changes.

  • fixes bug in NodeResolver where the instance of Wp class wasn't being passed properly as a reference
  • adds test to ensure filter runs and properly returns the $wp instance

Does this close any currently open issues?

closes #2377

…ng passed properly as a reference

- adds test to ensure filter runs and properly returns the $wp instance
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 63e186a and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.53% when pulling 63e186a on jasonbahl:bugfix/#2377-pass-wp-as-reference into ccaf4e6 on wp-graphql:develop.

@jasonbahl jasonbahl merged commit 531d2bb into wp-graphql:develop May 16, 2022
@jasonbahl jasonbahl mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning: Parameter 1 to Route::{closure}() expected to be a reference, value given

2 participants