Feature/#2275 multisite tests#2375
Merged
jasonbahl merged 8 commits intowp-graphql:developfrom May 13, 2022
Merged
Conversation
…folding WordPress for tests - update codeception.yml to use the MULTISITE env var when scaffolding WordPress for tests - add multisite to the matrix for the testing-integration workflow
…ectionResolver->get_connection() instead of ThemeConnectionResolver::resolve() - update ThemeConnectionResolver to pass `allowed => null` as an argument to - update ThemeConnectionQueriesTest to grant the admin user super admin privelages when querying themes. (@todo: add tests for regular admin users in multisite)
…fore trying to resolve it - add network active and network inactive plugins to the active/inactive plugins_by_status arrays in the plugin connection resolver - update "is_private" check on the Plugin Model to account for multisite permissions - update plugin tests to grant admin user super admin privelages (@todo add tests for multisite for regular admin (not super admin)
- update wpunit.suite.dist.yml to quote the multisite variable
Collaborator
|
@jasonbahl is there a reason this isnt based on the latest
|
Collaborator
Author
|
I typically start my feature branches off master. 🤷♂️ Based on current workflows it probably makes more sense to branch off develop though as develop almost always becomes the next release. |
|
Code Climate has analyzed commit b46e16f and detected 0 issues on this pull request. View more on Code Climate. |
This was referenced May 13, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This adds the ability to run unit tests in multisite. This also addresses some bugs related to multisite that were not caught when tests were not running in multisite.
Does this close any currently open issues?
closes #2275
related: #2363