Skip to content

chore: update PostObjectFieldFormatEnum value descriptions#2374

Merged
jasonbahl merged 1 commit intowp-graphql:developfrom
justlevine:chore/raw-format-enum-description
May 13, 2022
Merged

chore: update PostObjectFieldFormatEnum value descriptions#2374
jasonbahl merged 1 commit intowp-graphql:developfrom
justlevine:chore/raw-format-enum-description

Conversation

@justlevine
Copy link
Copy Markdown
Collaborator

What does this implement/fix? Explain your changes.

Changes the descriptions on PostObjectFieldFormatEnum to clarify default / unauthenticated behavior

Does this close any currently open issues?

#2301

Any relevant logs, error output, GraphiQL screenshots, etc?

image

Any other comments?

Opted to specify what happens on an unauthenticated request to directly address the confusion point for users.

Where has this been tested?

Operating System: Ubuntu 20.04 (WSL2 + devilbox + PHP 8.0.15

WordPress Version: 5.9.3

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 0063f76 and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine added type: enhancement Improvements to existing functionality status: in review Awaiting review before merging or closing labels May 13, 2022
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 79.324% when pulling 0063f76 on justlevine:chore/raw-format-enum-description into d38d5a9 on wp-graphql:develop.

@jasonbahl jasonbahl merged commit ccaf4e6 into wp-graphql:develop May 13, 2022
@justlevine justlevine deleted the chore/raw-format-enum-description branch May 13, 2022 21:39
@jasonbahl jasonbahl mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: in review Awaiting review before merging or closing type: enhancement Improvements to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants