(bugfix): Fix console warnings in WPGraphiQL related to missing keys#2354
Merged
jasonbahl merged 2 commits intowp-graphql:developfrom Apr 29, 2022
Merged
Conversation
- add key to auth switch component - add key to fullscreen toggle component - add key to AddOperation buttons
|
Code Climate has analyzed commit 89ca40c and detected 0 issues on this pull request. View more on Code Climate. |
Collaborator
|
Still getting warnings. I ran
|
Collaborator
|
Looks like
|
Collaborator
Author
|
@justlevine did you run I'm not seeing these console warnings anymore 🤔 (I just see the message about styled-components, but that's for another time)
|
Collaborator
Author
|
I think I see why these warnings were being output, but I'm curious why I'm not seeing them 🤔 I pushed up another change adding keys to the QueryComposer and Explorer components |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes some console warnings related to WPGraphiQL
Does this close any currently open issues?
closes #2352