Feat/user object mutation id inputs#2337
Conversation
063041d to
f4351e8
Compare
It's 1:00AM and im not by my pc, but if you dont figure it out before I come back online, i'll dig deeper and tackle the fix then 💤 |
|
@justlevine so you can change your env variable to make multisite tests run or not
I tend to run tests locally outside of docker (faster for me) so I can run them like so: From what I can tell, they're running as expected. |
I'm not by my computer, but that's the only reason I can think that the reassign test is failing now with a bad reassign, on all the tests (and not just 5.9 MU). Can be confirmed if you a put a |
…from_blog()` prior to calling `wpmu_delete_user()`
justlevine
left a comment
There was a problem hiding this comment.
Should this be in the is_multisite() check, or am I guilty of premature optimization?
src/Mutation/UserDelete.php
Outdated
| if ( ! function_exists( 'wpmu_delete_user' ) ) { | ||
| require_once ABSPATH . 'wp-admin/includes/ms.php'; | ||
| } | ||
| if ( ! function_exists( 'remove_user_from_blog' ) ) { |
There was a problem hiding this comment.
Should this be in the is_multisite() check, or am I guilty of premature optimization?
There was a problem hiding this comment.
nope, I was moving this already! The test actually didn't like it outside the is_multisite() call! So good suggestion 😄
There was a problem hiding this comment.
just pushed this change 😄
|
@justlevine I mistyped. instead of I can verify now by placing this inside the
|
|
Code Climate has analyzed commit ae5c89e and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |


What does this implement/fix? Explain your changes.
This PR enables users to supply either a database ID or a global ID to user mutation inputs of type ID. Part of #998
Does this close any currently open issues?
#2194
Any other comments?
…
Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.0.15)
WordPress Version: 5.9.2