Skip to content

Feat/term object mutation id inputs#2336

Merged
jasonbahl merged 5 commits intowp-graphql:developfrom
justlevine:feat/term-object-mutation-id-inputs
May 3, 2022
Merged

Feat/term object mutation id inputs#2336
jasonbahl merged 5 commits intowp-graphql:developfrom
justlevine:feat/term-object-mutation-id-inputs

Conversation

@justlevine
Copy link
Copy Markdown
Collaborator

@justlevine justlevine commented Apr 9, 2022

What does this implement/fix? Explain your changes.

This PR enables users to supply either a database ID or a global ID to term object mutation inputs of type ID. Part of #998

Does this close any currently open issues?

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.0.15)

WordPress Version: 5.9.2

@justlevine justlevine added type: enhancement Improvements to existing functionality needs: reviewer response This needs the attention of a codeowner or maintainer component: mutations Relating to GraphQL Mutations object type: term Relating to the Term Types scope: api Issues related to access functions, actions, and filters labels Apr 9, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 9, 2022

Coverage Status

Coverage increased (+0.02%) to 79.29% when pulling ee8b9ab on justlevine:feat/term-object-mutation-id-inputs into f7ebabb on wp-graphql:develop.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit ee8b9ab and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine added the status: in review Awaiting review before merging or closing label Apr 25, 2022
@jasonbahl jasonbahl merged commit c1c2255 into wp-graphql:develop May 3, 2022
@justlevine justlevine deleted the feat/term-object-mutation-id-inputs branch May 3, 2022 23:51
@jasonbahl jasonbahl mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: mutations Relating to GraphQL Mutations needs: reviewer response This needs the attention of a codeowner or maintainer object type: term Relating to the Term Types scope: api Issues related to access functions, actions, and filters status: in review Awaiting review before merging or closing type: enhancement Improvements to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants