feat: allow global/db ids in mediaItem mutation ID inputs#2331
Merged
jasonbahl merged 3 commits intowp-graphql:developfrom May 3, 2022
Merged
feat: allow global/db ids in mediaItem mutation ID inputs#2331jasonbahl merged 3 commits intowp-graphql:developfrom
jasonbahl merged 3 commits intowp-graphql:developfrom
Conversation
|
Code Climate has analyzed commit 1c76a0b and detected 0 issues on this pull request. View more on Code Climate. |
9 tasks
jasonbahl
approved these changes
May 3, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR enables users to supply either a database ID or a global ID to mediaItem mutation inputs of type ID. Part of #998 .
Does this close any currently open issues?
…
Any other comments?
The
mutate_and_get_payloadmethods were also refactored to bail earlier on failure and to remove some code duplication.Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.0.15)
WordPress Version: 5.9.2