#2274 - fix bug with the generalSettings.url field being removed #2276
Merged
jasonbahl merged 3 commits intowp-graphql:developfrom Mar 7, 2022
Conversation
…moved from multisite installs in the 1.7 release
…e (fixes sorting in the UpdateSettings payload) - use register_graphql_object_type instead of $this->register_object_type for the SettingsGroup to ensure filters are applied on fields
|
Code Climate has analyzed commit b94fccf and detected 0 issues on this pull request. View more on Code Climate. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This updates the call to
register_graphql_fieldto use$this->register_field()for the multisitegeneralSettings.urlfieldDoes this close any currently open issues?
closes #2274
Any relevant logs, error output, GraphiQL screenshots, etc?
Before (v1.6.12)
In v1.6.12, we can see that we can succesfully query for:
{ generalSettings { dateFormat url } }Regression (v1.7.1)
In v1.7.1 we can see that the same leads to an error, as the field
generalSettings.urlis not in the SchemaAfter (current PR)
With this change, we can query the field again:
Any other comments?
This PR doesn't have a test for this, as we don't have the test environment properly setup to run tests in multisite.
I created this issue (#2275) to follow-up.