Fix incorrect references to $query_args['search']#1819
Conversation
This breaks search results with pagination.
|
Oh nice! @benknight do you have interest in writing a test for this case to make sure we don't have a regression like this again? |
|
@jasonbahl actually while this change does fix a bug I'm not sure I would recommend merging it, because it's arguably likely to break search for a number of users -- basically in the current form, cursor pagination is broken, but search results are still (mostly) in order of relevance, especially for a single large query / when grabbing the first page. Merging this would cause search results to be ALL posts where the query "LIKE" matches the post title or post content, in a straight-up chronological order. The decision comes down to what is better - broken pagination or broken relevance. |
|
@benknight ok, ya, I think we need to get both working. I think the codebase is in a better spot now to support both. I'll see what I can work up! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issue and mark this as a related issue. |
Fixes #1818