Change type of tagId from String to Int#1779
Closed
rubas wants to merge 1 commit intowp-graphql:developfrom
rubas:patch-2
Closed
Change type of tagId from String to Int#1779rubas wants to merge 1 commit intowp-graphql:developfrom rubas:patch-2
tagId from String to Int#1779rubas wants to merge 1 commit intowp-graphql:developfrom
rubas:patch-2
Conversation
Probably just a typo for Tag. Personally I would suggest changing all of the ..Id to the type ID to be consistent.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issue and mark this as a related issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Change type of
tagIdfrom String to Int.Probably just a typo for tagId.
Any other comments?
I suggest changing all the
..Idto the typeIDto be consistent.