Skip to content

fix: support WordPress 7.0 in the integration test matrix#3960

Merged
jasonbahl merged 1 commit into
mainfrom
fix/wp-7.0-test-matrix
Jun 18, 2026
Merged

fix: support WordPress 7.0 in the integration test matrix#3960
jasonbahl merged 1 commit into
mainfrom
fix/wp-7.0-test-matrix

Conversation

@jasonbahl

Copy link
Copy Markdown
Collaborator

What

WordPress 7.0 has been released. This promotes it from the experimental "trunk" slot to the stable coverage tier in the integration test matrix (core, Smart Cache, and ACF; the IDE was already on 7.0), and fixes the two WP 7.0 changes that were making the trunk integration job fail on every PR.

Why

The "Integration: wp-graphql / WP trunk / PHP 8.4" job failed on every PR. It's experimental: true (continue-on-error), so it never blocked merges, but because it was permanently red it gave us no signal: a genuinely new trunk regression would have been invisible behind the same 10 known failures. Now that 7.0 is a required row, these failures had to be fixed or they'd start blocking merges.

Both failures were real WP 7.0 changes, reproduced locally against WP 7.0:

1. Default admin color scheme changed freshmodern

UserObjectQueriesTest::testUserAdminPreferencesDefaultValues hardcoded 'fresh'. It now derives the expected value the same way the resolver does (get_user_option('admin_color') with a 'fresh' fallback, per WPGraphQL\Model\User), so the assertion is no longer brittle across WordPress versions.

2. New core/breadcrumbs block double-registers in the test bootstrap

WP 7.0 ships the core/breadcrumbs block, which the test bootstrap registers twice, emitting a WP_Block_Type_Registry::register "already registered" incorrect-usage notice that failed all 9 I18nTest cases. The fix declares that single notice as expected on WP 7.0+ (version-guarded so the 6.x boundary rows stay clean). It's scoped narrowly on purpose, so the trunk job still surfaces any other incorrect-usage notice a future WordPress release introduces.

Matrix changes

Plugin Coverage Previous-stable boundary Oldest Experimental
wp-graphql 7.0 / 8.4 (×4 theme × multisite) 6.9 / 8.3 6.1 / 7.4 trunk
smart-cache 7.0 / 8.4 6.9 / 8.3 6.1 / 7.4 trunk
acf 7.0 / 8.4 (Pro + Ext Pro) 6.8 rows 6.2 / 7.4 trunk

The PHP version ladder (8.4 / 8.3 / 8.1 / 7.4) is preserved. Trunk stays experimental, now tracking 7.1-dev.

"Tested up to" headers

Bumped to 7.0 in core, Smart Cache, and ACF (ACF was a stale 6.5), in both the plugin header and readme.txt. The IDE was already at 7.0.

Testing

Verified locally against WordPress 7.0:

  • I18nTest — OK (9 tests, 34 assertions)
  • UserObjectQueriesTest::testUserAdminPreferencesDefaultValues — OK (1 test, 5 assertions)

ACF's 7.0 coverage is additionally backed by its already-passing trunk job (trunk ⊇ 7.0 changes).

WordPress 7.0 is released. Promote it from the experimental "trunk" slot
to the stable coverage tier across core, Smart Cache, and ACF (the IDE was
already on 7.0), and fix the two WP 7.0 changes that made the trunk
integration job fail on every PR. Because the job was permanently red, it
no longer signaled whether trunk/7.x was actually breaking WPGraphQL; these
fixes restore that signal.

Test fixes (verified locally against WP 7.0):

- UserObjectQueriesTest::testUserAdminPreferencesDefaultValues hardcoded the
  default admin color scheme as 'fresh'. WordPress 7.0 changed the default to
  'modern'. Derive the expected value the same way the resolver does
  (get_user_option('admin_color') with a 'fresh' fallback, per WPGraphQL\Model\User)
  so the assertion is no longer brittle across WordPress versions.

- I18nTest failed all 9 cases because WordPress 7.0 ships the core/breadcrumbs
  block, which the test bootstrap registers twice, emitting a
  WP_Block_Type_Registry::register "already registered" incorrect-usage notice.
  Declare that single notice as expected on WP 7.0+ (version-guarded so the 6.x
  boundary rows stay clean). The expectation is scoped to this one notice, so
  the trunk job still surfaces any other incorrect-usage notice a future
  WordPress release introduces.

Matrix: core/Smart Cache/ACF coverage rows move to WP 7.0 / PHP 8.4; the
previous-stable boundary moves to 6.9; trunk stays experimental (now 7.1-dev),
preserving the PHP version ladder.

Headers: bump "Tested up to" to 7.0 in core, Smart Cache, and ACF (was a stale
6.5) plugin headers and readme.txt files.
@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
wpgraphql-com Ready Ready Preview, Comment Jun 18, 2026 8:57pm

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.6%. Comparing base (5e5650e) to head (0f99674).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #3960      +/-   ##
=========================================
+ Coverage        0   83.6%   +83.6%     
- Complexity      0    5330    +5330     
=========================================
  Files           0     286     +286     
  Lines           0   22848   +22848     
=========================================
+ Hits            0   19096   +19096     
- Misses          0    3752    +3752     
Flag Coverage Δ
wp-graphql-acf-wpunit-twentytwentyfive-single 77.5% <ø> (?)
wp-graphql-wpunit-twentytwentyfive-multisite 84.6% <ø> (?)
wp-graphql-wpunit-twentytwentyfive-single 84.6% <ø> (?)
wp-graphql-wpunit-twentytwentyone-multisite 84.6% <ø> (?)
wp-graphql-wpunit-twentytwentyone-single 84.6% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 286 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasonbahl jasonbahl merged commit 391e7d3 into main Jun 18, 2026
89 of 93 checks passed
@jasonbahl jasonbahl deleted the fix/wp-7.0-test-matrix branch June 18, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant