Translations should only be called on/after init#363
Merged
benbalter merged 2 commits intowp-document-revisions:mainfrom May 21, 2025
Merged
Translations should only be called on/after init#363benbalter merged 2 commits intowp-document-revisions:mainfrom
benbalter merged 2 commits intowp-document-revisions:mainfrom
Conversation
Merge pull request wp-document-revisions#361 from NeilWJames/main
This comment was marked as outdated.
This comment was marked as outdated.
benbalter
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes have already been made to ensure translations are only done on/after the init hook.
WP 6.8 includes a doing_it_wrong call for translations - showing that the widget __construct call was being done during plugin_loaded, i.e. earlier that included translations.
This fix ensures that translation calls are not done prior to the init hook.