Skip to content

Update Rest tests#347

Merged
benbalter merged 5 commits intowp-document-revisions:mainfrom
NeilWJames:main
Apr 30, 2024
Merged

Update Rest tests#347
benbalter merged 5 commits intowp-document-revisions:mainfrom
NeilWJames:main

Conversation

@NeilWJames
Copy link
Copy Markdown
Collaborator

Latest WP version returns addition data in rest interface, so update test to a range check.

@NeilWJames NeilWJames assigned NeilWJames and benbalter and unassigned NeilWJames Apr 29, 2024
@codecov-commenter

This comment was marked as outdated.

@NeilWJames NeilWJames requested a review from benbalter April 29, 2024 20:04
@NeilWJames
Copy link
Copy Markdown
Collaborator Author

FWIW, WP versions prior to 6.5 returned an array of 24 items for attachments in the Rest interface - and was a successful test.

WP 6.5 included a fix 41692 - REST API does not return featured_media for Audio/Video, so this now returns 25 items. Hence the build failure.

This fix will deblock PR #346.

Copy link
Copy Markdown
Collaborator

@benbalter benbalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants