Address issue to release Version 3.6#330
Merged
benbalter merged 13 commits intowp-document-revisions:mainfrom Dec 6, 2023
Merged
Address issue to release Version 3.6#330benbalter merged 13 commits intowp-document-revisions:mainfrom
benbalter merged 13 commits intowp-document-revisions:mainfrom
Conversation
Merge pull request wp-document-revisions#323 from NeilWJames/main
Merge from wp-document-revisions
Update POT file
This comment was marked as outdated.
This comment was marked as outdated.
benbalter
approved these changes
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@benbalter
Sorry it has taken a time to revert with the fix to the problem I had raised with you to release V3.6.
I had hoped to address the issues for WPML.
Whilst I think think that I have them sorted (mentally at least), I think the most appropriate way to deal with it is to a plugin to go in the Cookbook that will be the functions to interface WPML, and to add filters and/or actions (if necessary) to the plugin.
I have changed the way the PDF image denotes that it has hidden itself to be better aligned with WPML processing. It will be marginally more efficient in processing than having a separate piece of metadata.
I have also fixed the issue raised today on Github which is a text typo.
Separately I wrote a document giving information on the data structures used. This was if I needed to go the the WPML folks to define how the plugin works. It certainly can be better written, but I thought it is better to be out there rather than simply on my PC.