Upgrade Version to 3.5#309
Merged
benbalter merged 68 commits intowp-document-revisions:mainfrom Feb 28, 2023
Merged
Conversation
Merge pull request wp-document-revisions#295 from NeilWJames/main
Merge post_date fix
Updates the requirements on [dealerdirect/phpcodesniffer-composer-installer](https://github.com/PHPCSStandards/composer-installer) to permit the latest version. - [Release notes](https://github.com/PHPCSStandards/composer-installer/releases) - [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator) - [Commits](PHPCSStandards/composer-installer@v0.7.0...v1.0.0) --- updated-dependencies: - dependency-name: dealerdirect/phpcodesniffer-composer-installer dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…ct/phpcodesniffer-composer-installer-tw-1.0 Update dealerdirect/phpcodesniffer-composer-installer requirement from ^0.7 to ^1.0
Update POT file
Update dealerdirect/phpcodesniffer-composer-installer requirement
Update POT file
This comment was marked as outdated.
This comment was marked as outdated.
benbalter
approved these changes
Feb 28, 2023
Collaborator
|
Wow, thanks for this @NeilWJames. Updated the required tests. I'll push up a new tag, which should automatically deploy to wordpress.org. 🚀 |
This was referenced Feb 28, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@benbalter,
This pull request addresses #306, #307 and #308 as well as the fixes mentioned in the changes text.
As it is over a year since the plugin has been updated, it probaby needs to be released to WP. That code still contains #283.
Whilst I have had to drop tests for PHP 5.6 and 7.0 als the WP polyfill process fails for these versions (WPTnitTestCase::setUp needs to return void and this is not supported until PHP 7.1), I have added an explicit test set using PHP 7.1 and WP 5.1. These are the earliest versions that currently work with the test suite.
I have modified the minimum supported WP version from 4.6 to 4.9. I have done this for two reasons. Although it is not a tested version, there is a good chance that it works with that version. There are folks that are using 4.9 still to avoid Gutenburg still and I would try to help them, but I do not have a lot of interest to attempt support the earlier versions.
I have added some tests to cover both the original post_content format (simple integer) or 3.4 format (html comment) as well as increasing the coverage percentage.
Thanks,
Neil James