Avoid test failure with assertNotSame instead of assertNotEquals#41
Merged
danielbachhuber merged 1 commit intomainfrom Apr 12, 2023
Merged
Avoid test failure with assertNotSame instead of assertNotEquals#41danielbachhuber merged 1 commit intomainfrom
assertNotSame instead of assertNotEquals#41danielbachhuber merged 1 commit intomainfrom
Conversation
It looks like `assertNotEquals` is doing a truthy comparison that causes the test to fail
Member
Author
|
@fjarrett I'm glad it turned out to be an easy fix 😌 |
Contributor
|
@danielbachhuber wondering if most |
Member
Author
|
@fjarrett Probably, but I don't really want to open that can of worms right now 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
assertNotEqualsis doing a truthy comparison that causes the test to fail.See wp-cli/wp-cli#5764