Merged
Conversation
2 tasks
swissspidy
approved these changes
Aug 30, 2023
swissspidy
reviewed
Aug 30, 2023
| <!-- Allow filesystem operations because WordPress APIs may not be available --> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_file_put_contents" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_mkdir" /> | ||
| <exclude name="WordPress.WP.AlternativeFunctions.file_system_operations_rmdir" /> |
Member
There was a problem hiding this comment.
Let's also add is_writable()
jrfnl
reviewed
Aug 30, 2023
| "wp-cli/eval-command": "^1 || ^2", | ||
| "wp-cli/wp-cli": "^2.5.1", | ||
| "wp-coding-standards/wpcs": "^2.3.0", | ||
| "wp-coding-standards/wpcs": "^3", |
Contributor
There was a problem hiding this comment.
Recommended: remove the explicit dealerdirect/phpcodesniffer-composer-installer require. That now comes with WPCS and removing it will prevent potential future version conflicts.
jrfnl
reviewed
Aug 30, 2023
Comment on lines
1098
to
1099
| $error = error_get_last(); | ||
| throw new RuntimeException( sprintf( "Failed to copy '%s' to '%s': %s. " . __FILE__ . ':' . __LINE__, $upd_file, $cop_file, $error['message'] ) ); |
Contributor
There was a problem hiding this comment.
Looks like the indent here didn't get fixed ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #175
Fixes wp-cli/wp-cli-dev#47