Address PHPUnit deprecation #6195
Conversation
Reported by PHPStan. See sebastianbergmann/phpunit#6461
This comment was marked as resolved.
This comment was marked as resolved.
Summary of ChangesHello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a PHPUnit deprecation warning identified by PHPStan. The change updates the mock object creation pattern within a test file to align with modern PHPUnit practices, ensuring the test suite remains compatible and free of deprecation notices. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Code Review
This pull request successfully addresses the PHPUnit deprecation by updating the mock object creation and method expectation syntax in tests/UtilsTest.php. The change correctly aligns with modern PHPUnit practices, improving the maintainability of the test suite. Additionally, the removal of the @phpstan-ignore class.notFound annotation indicates that PHPStan can now correctly resolve the WP_CLI_Mock_WPDB interface, which is a positive step for static analysis and overall code quality.
Reported by PHPStan. See https://github.com/wp-cli/wp-cli/actions/runs/21033856033/job/60480486375?pr=6194 and sebastianbergmann/phpunit#6461