Improve Process class for Windows
#6124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1 task
Member
|
Is there a way to update wp-cli/wp-cli-tests#274 temporarily to use this branch and see that it fixes the problem? Looks OK at a glance but so did the previous code : ) |
Contributor
|
Update branch is a matter of PR against wp-cli/wp-cli-tests#274 branch and it meagre. |
Member
Author
|
I think that is always a bit messy with Composer because both packages depend on each other. But before wp-cli/wp-cli-tests@b44d869 I did use this changed class in that PR and it worked great. I just reverted it there for the review. |
Member
Author
|
nvm, it seems to work: wp-cli/wp-cli-tests#274 |
mrsdizzie
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while working on wp-cli/wp-cli-tests#274, this improves sub-process creation on Windows by redirecting output to files
Previously, created processes during Behat tests would just hang indefinitely.