Skip to content

Handle optional option values in SynopsisParser::render() #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 3 commits into from
Jun 30, 2022
Merged

Handle optional option values in SynopsisParser::render() #5618

schlessera merged 3 commits into from
Jun 30, 2022

Conversation

@ssnepenthe
Copy link
Contributor

@ssnepenthe ssnepenthe commented Feb 7, 2022

Fixes #5617

@ssnepenthe ssnepenthe requested a review from a team as a code owner February 7, 2022 20:57
wojsmol
wojsmol reviewed Feb 7, 2022
View reviewed changes
@ssnepenthe
Copy link
Contributor Author

ssnepenthe commented Jun 22, 2022

@wojsmol is there anything else that needs to be addressed in order for the pr to be merged?

@schlessera schlessera added this to the 2.7.0 milestone Jun 30, 2022
@schlessera schlessera merged commit 5508a6d into wp-cli:master Jun 30, 2022
@schlessera schlessera changed the title Handle optional option values in SynopsisParser::render() Handle optional option values in SynopsisParser::render() Jun 30, 2022
@drzraf
Copy link

drzraf commented Feb 21, 2023

I believe the combination with default doesn't work. (It'd gives true as a value instead of the one defined by default contrary to the string-based synopsis)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

+1 more reviewer

@wojsmol wojsmol wojsmol left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

scope:framework

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

Unable to register option with optional value using array synopsis syntax

4 participants

@ssnepenthe @drzraf @schlessera @wojsmol