Skip to content

Throw exception when misusing error_to_string() #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 3 commits into from
Jun 4, 2020
Merged

Throw exception when misusing error_to_string() #5405

schlessera merged 3 commits into from
Jun 4, 2020

Conversation

@vsamoletov
Copy link
Contributor

@vsamoletov vsamoletov commented Jun 4, 2020 •
edited by schlessera
Loading

Fixes #5356

@vsamoletov vsamoletov requested a review from a team as a code owner June 4, 2020 13:24
swissspidy
swissspidy reviewed Jun 4, 2020
View reviewed changes
@vsamoletov
Copy link
Contributor Author

vsamoletov commented Jun 4, 2020

I have to add @throws to PHPDoc probably. Please let me know.

@vsamoletov @swissspidy
Redundant casting removed
de5e261 
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@swissspidy swissspidy requested a review from a team June 4, 2020 13:47
@vsamoletov
Copy link
Contributor Author

vsamoletov commented Jun 4, 2020

@swissspidy could you please also review 68d96c9

@vsamoletov vsamoletov requested a review from swissspidy June 4, 2020 14:08
@swissspidy swissspidy requested a review from a team June 4, 2020 14:18
@swissspidy swissspidy requested a review from schlessera June 4, 2020 14:18
@schlessera schlessera changed the title Fixes: #5356 Throw exception when misusing error_to_string() Jun 4, 2020
@schlessera schlessera added the bug label Jun 4, 2020
@schlessera schlessera added this to the 2.5.0 milestone Jun 4, 2020
@schlessera schlessera merged commit d7df11b into wp-cli:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

WP_CLI::error_to_string() doesn't have a guaranteed return value

3 participants

@vsamoletov @schlessera @swissspidy