Check for readablity of WordPress core files#4626
Merged
schlessera merged 2 commits intowp-cli:masterfrom Jan 23, 2018
Merged
Conversation
schlessera
approved these changes
Jan 23, 2018
Member
|
Thanks for the PR, @websupporter ! |
Contributor
|
Just noting we never added tests for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR checks for the existing of WordPress with
file_exists( ABSPATH . '/wp-includes/version.php' )and in a separate check for the readability of this file.This way, we can give a more precise error message. If its a readability problem, this PR sends
It seems, the WordPress core files do not have the proper file permissions.and otherwise the known error message.This solves #4594
Thank you :)