Conversation
gitlost
approved these changes
Jan 19, 2018
gitlost
reviewed
Jan 19, 2018
| * @return bool Whether the provided string is a valid JSON representation. | ||
| */ | ||
| function is_json( $argument, $ignore_scalars = true ) { | ||
| if ( empty( $argument ) || ! is_string( $argument ) ) { |
Contributor
There was a problem hiding this comment.
To be picky this should be if ( ! is_string( $argument ) || 0 === strlen( $argument ) ) { to deal with if given '0'.
Member
Author
There was a problem hiding this comment.
Picky is good. Why did you merge anyway?
I'll add a bug report as a good first issue.
Contributor
There was a problem hiding this comment.
Ha, I merged because we've so many bugs, PRs and other stuff outstanding and release is 8 days from now!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two helper functions:
WP_CLI\Utils\parse_shell_arrays( $assoc_args, $array_arguments )This takes an existing
$assoc_argsarray, and parses possible shell arguments for all keys that are provided in$array_argumentsWP_CLI\Utils\is_json( $argument, $ignore_scalars = true )Helper function for the above parsing, that detects whether a given string is valid JSON.
See #4616