Added interval argument to make_progress_bar()#4603
Merged
gitlost merged 3 commits intowp-cli:masterfrom Jan 9, 2018
Merged
Conversation
Allows to set update interval, available in class constructor but not previously accepted by function wrapper.
gitlost
suggested changes
Jan 9, 2018
php/utils.php
Outdated
| * | ||
| * @param string $message Text to display before the progress bar. | ||
| * @param integer $count Total number of ticks to be performed. | ||
| * @param int $interval The interval in milliseconds between updates. |
Contributor
There was a problem hiding this comment.
Extra space before the "The". Also could you expand the comment to
Optional. The interval in milliseconds between updates. Default 100.
?
Contributor
Author
There was a problem hiding this comment.
I copy/pasted the doc from the implementing class, would you like wording updated there as well for consistency?
Contributor
There was a problem hiding this comment.
Well, it'd be nice, but probably not worth it!
Contributor
Author
There was a problem hiding this comment.
Yeah, the class is upstream in PHP CLI tools so not worth it. :)
gitlost
approved these changes
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to set update interval, available in class constructor but not previously accepted by function wrapper.