Only provide dictionary-based suggestions if they produce valid options.#4590
Merged
schlessera merged 2 commits intomasterfrom Dec 28, 2017
Merged
Only provide dictionary-based suggestions if they produce valid options.#4590schlessera merged 2 commits intomasterfrom
schlessera merged 2 commits intomasterfrom
Conversation
As there is some overlap between parameters across commands, we need to make sure the dictionary of hard-coded suggestions doesn't get blindly applied to commands it wasn't meant for. Fixes #4578
swissspidy
approved these changes
Dec 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there is some overlap between parameters across commands, we need to make sure the dictionary of hard-coded suggestions doesn't get blindly applied to commands it wasn't meant for.
Fixes #4578