Initial implementation of command namespaces.#4470
Merged
danielbachhuber merged 4 commits intomasterfrom Oct 30, 2017
Merged
Conversation
A command namespace is a command placeholder that can receive annotations, sub-commands and all other shenanigans that a normal composite command can have, with the following changes: * A namespace will never replace a previously added command of the same name. * A namespace will always be replaced by a command of the same name that is added later. * An empty namespace shows a corresponding notice when invoked. See #4385
PHPCS seems to be too stupid to differentiate between _indentation_ and _alignment_... 😠
| * @param string $name Represents how the command should be invoked | ||
| * @param mixed $callable | ||
| */ | ||
| private static function create_namespace( $parent, $name, $callable ) { |
Member
There was a problem hiding this comment.
Should we enforce any specific characteristics of the class (e.g. no defined methods, must extend some base class, etc.)?
Also, what happens if this isn't a class? WP_CLI::add_command() accepts any callable.
Member
Author
There was a problem hiding this comment.
This is a private helper method. The $callable was already checked before to assert that it is a subclass of the namespace class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A command namespace is a command placeholder that can receive annotations, sub-commands and all other shenanigans that a normal composite command can have, with the following changes:
See #4385