Provide dictionary-based suggestions for common misspellings#4392
Merged
schlessera merged 1 commit intowp-cli:masterfrom Oct 5, 2017
n8finch:master
Merged
Provide dictionary-based suggestions for common misspellings#4392schlessera merged 1 commit intowp-cli:masterfrom n8finch:master
schlessera merged 1 commit intowp-cli:masterfrom
n8finch:master
Conversation
danielbachhuber
approved these changes
Oct 4, 2017
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks @n8finch ! Looks good on my end. I'll let @schlessera weigh in with his opinion/any requested changes.
Contributor
Author
|
Sounds good, and thanks! |
Member
|
Looks good to me! I'll merge the current collection, we can always add more later on. Thanks for the work on this, @n8finch ! |
schlessera
approved these changes
Oct 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks!
This PR seeks to get the ball rolling on (or resolve) this issue: #4379
Per Alain's leading, I've added in the
$suggestion_maparray and the return check.Several items in the array are used across different commands (e.g.,
wp post newandwp db newwould both return the correct suggestion:Did you mean 'create'?I've label this as a WIP, so happy to make edits or expand this.
Thanks!
Nate