Skip to content

Fail back to tar xz when PharData throws an Exception#4371

Merged
miya0001 merged 3 commits intomasterfrom
fail-back
Sep 21, 2017
Merged

Fail back to tar xz when PharData throws an Exception#4371
miya0001 merged 3 commits intomasterfrom
fail-back

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Sep 20, 2017

In certain systems, PharData fails on invalid archives that tar can
successfully handle.

See #4370

@danielbachhuber
Fail back to tar xz when PharData throws an Exception
90dfa6c 
In certain systems, `PharData` fails on invalid archives that `tar` can
successfully handle.
@danielbachhuber danielbachhuber added this to the 1.4.0 milestone Sep 20, 2017
@danielbachhuber danielbachhuber requested a review from a team September 20, 2017 23:48
@danielbachhuber danielbachhuber mentioned this pull request Sep 20, 2017
Closed
@JPry
Copy link
Contributor

JPry commented Sep 21, 2017

I tested this with my local VVV instance and the nightly phar, and it worked.

vagrant@vvv:/tmp$ mkdir test
vagrant@vvv:/tmp$ cd test/
vagrant@vvv:/tmp/test$ php ../wp-cli-nightly.phar core download
Downloading WordPress 4.8.2 (en_US)...
md5 hash verified: 2e8744a702a3d9527782d9135a4c9544
Warning: unable to decompress gzipped phar archive "/tmp/wp_59c2ff8e7af4a.tar.gz" to temporary file
Success: WordPress downloaded.

Slack message: https://wordpress.slack.com/archives/C02RP4T41/p1505951665000145?thread_ts=1505948297.000185&cid=C02RP4T41

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Sep 21, 2017

Updating the warning to:

Warning: PharData failed, falling back to 'tar gz' (unable to decompress gzipped phar archive "/tmp/wp_59c2ff8e7af4a.tar.gz" to temporary file)

miya0001
miya0001 approved these changes Sep 21, 2017
View reviewed changes
Copy link
Member

@miya0001 miya0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miya0001 miya0001 merged commit ee6aed3 into master Sep 21, 2017
@schlessera schlessera deleted the fail-back branch September 21, 2017 09:30
@gitlost gitlost mentioned this pull request Oct 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@miya0001 miya0001 miya0001 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

scope:framework

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@danielbachhuber @JPry @miya0001