Skip to content

coding standards fixes - utils/make-phar.php#3702

Closed
miya0001 wants to merge 1 commit intowp-cli:masterfrom
miya0001:cs-utils-make-phar-php
Closed

coding standards fixes - utils/make-phar.php#3702
miya0001 wants to merge 1 commit intowp-cli:masterfrom
miya0001:cs-utils-make-phar-php

Conversation

@miya0001
Copy link
Copy Markdown
Member

I started to fix coding standards.
When I have a moment, I will send a PR.

Actually, I did it for some files.
https://github.com/miya0001/wp-cli/commits/coding-standard

But I will send a pull request as an each file because I want to see the result of Travis CI.

The ruleset is following.

<?xml version="1.0"?>
<ruleset name="WordPress Coding Standards via https://github.com/Automattic/_s/blob/master/codesniffer.ruleset.xml">
	<!-- See https://github.com/squizlabs/PHP_CodeSniffer/wiki/Annotated-ruleset.xml -->
	<!-- See https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/develop/WordPress-Core/ruleset.xml -->

	<!-- Set a description for this ruleset. -->
	<description>A custom set of code standard rules to check for WP-CLI</description>

	<exclude-pattern>vendor/*</exclude-pattern>
	<exclude-pattern>codesniffer/*</exclude-pattern>
	<exclude-pattern>PHP_Codesniffer-VariableAnalysis/*</exclude-pattern>

	<!-- Include the WordPress ruleset, with exclusions. -->
	<rule ref="WordPress">
		<exclude name="Squiz.Commenting.FunctionComment.Missing" />
		<exclude name="Squiz.Commenting.ClassComment.Missing" />
		<exclude name="Squiz.Commenting.FileComment.Missing" />
		<exclude name="Generic.WhiteSpace.ScopeIndent.IncorrectExact" />
		<exclude name="Generic.WhiteSpace.ScopeIndent.Incorrect" />
		<exclude name="PEAR.Functions.FunctionCallSignature.Indent" />
		<exclude name="WordPress.XSS.EscapeOutput.OutputNotEscaped" />
		<exclude name="WordPress.VIP.FileSystemWritesDisallow.FileWriteDetected" />
	</rule>
</ruleset>

@danielbachhuber
Copy link
Copy Markdown
Member

Thanks for the initiative, @miya0001

I started to fix coding standards.
When I have a moment, I will send a PR.

Can you open an issue to discuss this first, please? I'm not sure how I feel about embarking on this task. It'd be worthwhile to discuss the pros and cons first.

@miya0001 miya0001 mentioned this pull request Dec 31, 2016
@danielbachhuber
Copy link
Copy Markdown
Member

See #3703 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants