coding standards fixes - utils/make-phar.php#3702
Closed
miya0001 wants to merge 1 commit intowp-cli:masterfrom
miya0001:cs-utils-make-phar-php
Closed
coding standards fixes - utils/make-phar.php#3702miya0001 wants to merge 1 commit intowp-cli:masterfrom miya0001:cs-utils-make-phar-php
miya0001 wants to merge 1 commit intowp-cli:masterfrom
miya0001:cs-utils-make-phar-php
Conversation
Member
|
Thanks for the initiative, @miya0001
Can you open an issue to discuss this first, please? I'm not sure how I feel about embarking on this task. It'd be worthwhile to discuss the pros and cons first. |
Closed
Member
|
See #3703 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started to fix coding standards.
When I have a moment, I will send a PR.
Actually, I did it for some files.
https://github.com/miya0001/wp-cli/commits/coding-standard
But I will send a pull request as an each file because I want to see the result of Travis CI.
The ruleset is following.