Use --no-auto-rehash for MySQL commands by default, for performance boost#1664
Use --no-auto-rehash for MySQL commands by default, for performance boost#1664mwithheld wants to merge 3 commits intowp-cli:masterfrom mwithheld:patch-1
Conversation
Add --no-auto-rehash to mysql CLI options, disabling name completion to speed up non-interactive query processing.
|
Do you have some stats that show the execution time before and after applying the patch? |
|
We've got ~4000 tables on a remote server at the moment. With auto-rehash starting mysql takes ~2-3 minutes to gather the table and column names before it'll actually run a query. |
Move mysql --no-defaults param before --no-auto-rehash b/c mysql cares about param order in this case.
|
I don't really understand why the build is failing on this now (https://travis-ci.org/wp-cli/wp-cli/jobs/51318140). The output shows a bunch of rows and then says there isn't any rows. |
|
It looks like 4.1.1 has just came out. |
|
Do I need to re-commit now that build 3707 (fixing the version check to allow 4.1.1) has gone through? |
|
This PR is OK. Only |
|
@mwithheld Can you merge master into this PR so we get a successful build? |
|
I don't know how to do that, sorry. I've rebased my clone if that helps. |
|
I've created a clean PR in #1668. We'll see if that does the trick. |
Add --no-auto-rehash to mysql CLI options, disabling name completion to speed up non-interactive query processing.