Skip to content

Clean up disabled WPCS sniffs #4058

@danielbachhuber

Description

@danielbachhuber

Many sniffs were disabled in a57b9fb (#4057).

We should eventually restore them, and then clean up affected files. When we restore them, it would be helpful to only restore one sniff per pull request to make the file churn easily understandable.

  • Generic.ControlStructures.InlineControlStructure.NotAllowed
  • Generic.Formatting.DisallowMultipleStatements.SameLine
  • Generic.Formatting.SpaceAfterCast.NoSpace
  • Generic.Functions.OpeningFunctionBraceKernighanRitchie.ContentAfterBrace
  • Generic.Functions.OpeningFunctionBraceKernighanRitchie.SpaceBeforeBrace
  • Generic.PHP.LowerCaseKeyword.Found
  • Generic.PHP.LowerCaseConstant.Found
  • Generic.PHP.NoSilencedErrors.Discouraged
  • Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
  • Generic.WhiteSpace.ScopeIndent.Incorrect
  • Generic.WhiteSpace.ScopeIndent.IncorrectExact
  • PEAR.Functions.FunctionCallSignature.Indent
  • PEAR.Functions.FunctionCallSignature.EmptyLine
  • PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
  • PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket
  • PEAR.Functions.FunctionCallSignature.SpaceBeforeOpenBracket
  • PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
  • Squiz.Strings.ConcatenationSpacing.PaddingFound
  • Squiz.ControlStructures.ControlSignature.SpaceAfterKeyword
  • Squiz.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis
  • Squiz.Commenting.LongConditionClosingComment.Missing
  • Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterOpen
  • Squiz.PHP.DisallowMultipleAssignments.Found
  • Squiz.Strings.DoubleQuoteUsage.NotRequired
  • Squiz.WhiteSpace.SuperfluousWhitespace.EndLine
  • WordPress.Arrays.ArrayDeclaration.NotLowerCase
  • WordPress.Arrays.ArrayDeclaration.NoComma
  • WordPress.Arrays.ArrayDeclaration.NoCommaAfterLast
  • WordPress.Arrays.ArrayDeclaration.SpaceAfterKeyword
  • WordPress.Arrays.ArrayDeclarationSpacing.AssociativeKeyFound
  • WordPress.Arrays.ArrayDeclarationSpacing.NoSpaceAfterArrayOpener
  • WordPress.Arrays.ArrayDeclarationSpacing.NoSpaceBeforeArrayCloser
  • WordPress.Arrays.ArrayKeySpacingRestrictions.SpacesAroundArrayKeys
  • WordPress.Arrays.ArrayKeySpacingRestrictions.NoSpacesAroundArrayKeys
  • WordPress.DB.RestrictedFunctions.mysql_mysql_host_to_cli_args
  • WordPress.Files.FileName.InvalidClassFileName
  • WordPress.Files.FileName.NotHyphenatedLowercase
  • WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
  • WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
  • WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar
  • WordPress.NamingConventions.ValidVariableName.MemberNotSnakeCase
  • WordPress.NamingConventions.ValidVariableName.NotSnakeCase
  • WordPress.PHP.YodaConditions.NotYoda
  • WordPress.WhiteSpace.CastStructureSpacing.NoSpaceBeforeOpenParenthesis
  • WordPress.WhiteSpace.CastStructureSpacing.NoSpaceAfterCloseParenthesis
  • WordPress.WhiteSpace.ControlStructureSpacing.BlankLineAfterEnd
  • WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterStructureOpen
  • WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterOpenParenthesis
  • WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeOpenParenthesis
  • WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterCloseParenthesis
  • WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeCloseParenthesis
  • WordPress.WhiteSpace.ControlStructureSpacing.ExtraSpaceAfterOpenParenthesis
  • WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter
  • WordPress.WhiteSpace.OperatorSpacing.NoSpaceBefore

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions