Skip to content

Use phpunit 6.5.6 for PHP 7.2 to get around core test incompat.#125

Merged
schlessera merged 2 commits intomasterfrom
php-7.2-use-phpunit-6.5.6
Feb 20, 2018
Merged

Use phpunit 6.5.6 for PHP 7.2 to get around core test incompat.#125
schlessera merged 2 commits intomasterfrom
php-7.2-use-phpunit-6.5.6

Conversation

@gitlost
Copy link
Contributor

@gitlost gitlost commented Feb 18, 2018

See #118 (comment) and https://core.trac.wordpress.org/ticket/43218

Temporary fix to use phpunit 6.5.6 if PHP 7.2 until the core test suite is made PHP 7.2 phpunit 7.0.0 compat. Will need to be merged into outstanding PRs.

@gitlost gitlost added the scope:testing Related to testing label Feb 18, 2018
@gitlost gitlost added this to the 1.1.3 milestone Feb 18, 2018
@gitlost gitlost requested a review from a team February 18, 2018 18:53
@tfirdaus tfirdaus mentioned this pull request Feb 19, 2018
@schlessera schlessera merged commit 94ead52 into master Feb 20, 2018
@schlessera schlessera deleted the php-7.2-use-phpunit-6.5.6 branch February 20, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants