update-po: Check for destination#356
Merged
swissspidy merged 1 commit intowp-cli:mainfrom Mar 18, 2023
Merged
Conversation
35a04db to
f9fc458
Compare
1 task
update-po: Check for destination
swissspidy
reviewed
Mar 17, 2023
swissspidy
reviewed
Mar 17, 2023
f9fc458 to
7107fb9
Compare
7107fb9 to
d941666
Compare
swissspidy
approved these changes
Mar 18, 2023
Member
swissspidy
left a comment
There was a problem hiding this comment.
Woohoo! Thanks a lot for fixing this bug and also including tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included a check if the destination is not either a file or a directory. In that case return an WP_CLI error instead of Fatal Error. Functional tests added as well.
Fixes #332