Skip to content

Update and combine theme.json and block.json extractors#319

Merged
swissspidy merged 6 commits intomainfrom
fix/287-block-schema
Jul 4, 2022
Merged

Update and combine theme.json and block.json extractors#319
swissspidy merged 6 commits intomainfrom
fix/287-block-schema

Conversation

@swissspidy
Copy link
Member

@swissspidy swissspidy commented May 2, 2022 •
edited
Loading

Uses the block-i18n.json schema file to determine which fields are translatable.

Enhancement: Adds support for translating block variation fields. Apparently these were not extracted before...

Fixes #287

@swissspidy swissspidy requested a review from a team as a code owner May 2, 2022 13:38
@swissspidy
Copy link
Member Author

swissspidy commented May 2, 2022

cc @gziolo

@swissspidy swissspidy added this to the 2.4.0 milestone May 2, 2022
@swissspidy
Copy link
Member Author

swissspidy commented May 2, 2022

Looks like the existing theme i18n schema parser does not support cases like

  "keywords": [ "block keyword" ],

as seen in block.json

So that needs some fiddling to enable support and make the tests pass

@swissspidy
Copy link
Member Author

swissspidy commented May 2, 2022

@schlessera I'm running into some fatal errors here on PHP < 7.4. Perhaps you have some ideas here? Not sure which one of my changes could have caused that...

@schlessera
Copy link
Member

schlessera commented May 3, 2022

@swissspidy The problem was the use of private access in the IterableCodeExtractor trait. That worked fine until you extended a class that was using that trait.

@swissspidy
Copy link
Member Author

swissspidy commented May 3, 2022

Ah 💡 🤦 Thanks!

@swissspidy swissspidy changed the title Combine theme.json and block.json extractor classes Update and combine theme.json and block.json extractors May 3, 2022
@gziolo
Copy link
Contributor

gziolo commented May 4, 2022

I think it's a good idea to use the file from wordpress-develop for now. I'm still not sure whether using the canonical URL similar to https://schemas.wp.org/trunk/block.json as discussed in the parent issue would work so nicely as it can be ahead of WordPress core.

Anyway, it looks like this PR has everything covered. Nice work, thank you for bringing i18n schemas up to date ❤️

@swissspidy swissspidy mentioned this pull request May 10, 2022
Closed
2 tasks
schlessera
schlessera requested changes Jul 4, 2022
View reviewed changes
@swissspidy @schlessera
Apply suggestions from code review
9b38df5 
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
@swissspidy swissspidy requested a review from schlessera July 4, 2022 16:04
@swissspidy swissspidy merged commit cd25bd6 into main Jul 4, 2022
@swissspidy swissspidy deleted the fix/287-block-schema branch July 4, 2022 16:24
Copilot AI mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

command:i18n-make-pot

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

Use i18n schema for block.json from WordPress Core

3 participants

@swissspidy @schlessera @gziolo