Look for theme.json files in the styles directory of a theme#311
Merged
swissspidy merged 4 commits intowp-cli:mainfrom Mar 31, 2022
oandregal:add/global-style-variations
Merged
Look for theme.json files in the styles directory of a theme#311swissspidy merged 4 commits intowp-cli:mainfrom oandregal:add/global-style-variations
theme.json files in the styles directory of a theme#311swissspidy merged 4 commits intowp-cli:mainfrom
oandregal:add/global-style-variations
Conversation
Contributor
Author
|
cc @swissspidy this is the continuation of #306 |
Contributor
Author
|
The behat tests are now throwing the following warning (hence they fail):
This warning also happens in The reason for this warning is that the i18n schema used to translate |
Member
|
Merged #306 now |
swissspidy
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #306
It adds supports for looking for translatable strings in JSON files within the
stylesdirectory of a theme. Unlike the top-leveltheme.jsonfile we don't lock any names in this case: any JSON file within thestylesfolder is a candidate we should consider.How to test
Automated tests:
composer behat -- features/makepot.featureManual test:
composer installfoo-themethat contains astylesdirectory.stylesdirectory create amy-style.jsonfile with the following contents:{ "settings": { "color": { "palette": [ { "name": "My color", "slug": "slug", "color": "value" } ] } } }vendor/bin/wp i18n make-pot foo-themefoo-theme/foo-theme.potfile and that the "My color" string is present as well as its context "Color name". You should see something like: