Fix include logic where include path is subdirectory of excluded path.#302
Merged
swissspidy merged 2 commits intowp-cli:mainfrom Jan 19, 2022
Merged
Conversation
swissspidy
reviewed
Jan 17, 2022
Member
|
Thanks a lot for this PR! |
No yoda condition. Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
Contributor
Author
|
@swissspidy I'm not rushing but just want to make sure if there is any action item on my side. |
swissspidy
approved these changes
Jan 19, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172.
Changes in this PR:
containsMatchingChildren(), so $root_relative_path doesn't have trailing slash. [#]. This is because$includeand$excludeare trailing-slash-trimmed, so if$root_relative_pathisn't, this clause won't be true as expected.