-
Notifications
You must be signed in to change notification settings - Fork 355
Fix docblock parser to handle multiline descriptions for all tags #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser now correctly handles multiline @param descriptions that end with commas or other characters (not just '{'). Changes: - When in $in_param mode, continue parsing until we hit another @ tag - Always set $in_param for @param tags (not just when description ends with '{') - Remove the check for '}' as the end condition for multiline params Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Address code review feedback to prevent undefined index error when $info is empty Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix parsing issue with multiline argument description
Fix docblock parser to handle multiline @param descriptions
Dec 8, 2025
Member
|
@copilot I need to handle multiline |
Contributor
Author
Copilot
AI
changed the title
Fix docblock parser to handle multiline @param descriptions
Fix docblock parser to handle multiline descriptions for all tags
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docblock parser was truncating multiline descriptions when the first line didn't end with
{. This affected@paramdescriptions inUtils\http_request()(e.g., the$dataparameter lost its continuation line "or in the body for POST requests.") and would similarly affect@return,@throws, and other docblock tags.Root cause: Parser only tracked multiline descriptions when they ended with
{, ignoring other line-ending characters like commas.Changes:
$in_paramfor all docblock tags (@param,@return,@throws, etc.), not just those ending with{@tag instead of checking for}Testing:
Verified that multiline descriptions work correctly for:
@paramtags (original issue)@returntags@throwstagsOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.