For Github archive URLs use the Github project name as the plugin directory.#81
Merged
schlessera merged 1 commit intomasterfrom Jan 24, 2018
Merged
Conversation
schlessera
approved these changes
Jan 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
Uses the Github project name as a guess for the plugin directory when given an archive URL (which the current code attempts but fails when there's an intervening
versionin the URL).Refactors the code to be more explicit about what it's doing.
Also unrelatedlly fixes typo "ambigious" -> "ambiguous" and cleans up some tests.
Re not using
composer.jsonor reading the plugin info, there is actually nothing in WP that says what the plugin directory should be, apart from the directory in the zip. So the functionality here is just a workaround for Github zip's not having the correct directory.A better solution would be to have an option to say what the plugin directory should be, but this will have to be formulated to deal with multiple installs (in some fashion or other) so will have to wait for the moment.