Don't use transient values when doing wp plugin|theme list #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
f37da9c to
8f4976f
Compare
This changes the default behavior to always check wordpress.org for the latest information when doing wp plugin|theme list unless the existing `--skip-update-check` flag is passed.
8f4976f to
456a1ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default behavior to always check wordpress.org for the latest information when doing wp plugin|theme list unless the existing
--skip-update-checkflag is passed.This came out of the discussion in #426 and replaces that PR. The main idea is that it doesn't make any sense to have both
--force-checkand--skip-update-checkflags while also having the default behavior be unpredictable depending on the state of the transient.I created a new PR since pretty much all of the code is test code and that is different now that we are changing the default behavior instead of adding a flag.