Delete plugin translation files when plugin is uninstalled#339
Merged
danielbachhuber merged 7 commits intowp-cli:masterfrom Nov 10, 2022
Merged
Conversation
danielbachhuber
approved these changes
Nov 10, 2022
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for your work on this, @agrullon95 !
I made one tweak to your conditional so uninstall_plugin( $plugin->file ); is always called. There was a failure otherwise.
I also added a feature test, if you want to take a look at that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, plugin translation files are not deleted from
/wp-content/languages/pluginswhen a plugin is uninstalled using wp-cli.With these changes, file translation files will also be deleted when a plugin is uninstalled.
Testing instructions
wp plugin install [PLUGIN-NAME]wp language plugin install [PLUGIN-NAME] [language]Example:
Access
/wp-content/languages/pluginsand verify you see the language files for the plugin you installed.wp plugin uninstall [PLUGIN-NAME].Fixes #337