Skip to content

Replace one-time-login with a sample plugin in the tests#302

Merged
schlessera merged 4 commits intowp-cli:masterfrom
Nikschavan:301-php56-tests
Oct 13, 2021
Merged

Replace one-time-login with a sample plugin in the tests#302
schlessera merged 4 commits intowp-cli:masterfrom
Nikschavan:301-php56-tests

Conversation

@Nikschavan
Copy link
Contributor

Fixes #301

Replaces the plugin one-time-login with a sample WordPress plugin

@Nikschavan Nikschavan requested a review from a team as a code owner October 11, 2021 16:12
@swissspidy
Copy link
Member

@schlessera Should this sample plugin live in the wp-cli org so that we can guarantee it exists? In case https://github.com/Nikschavan/test-wordpress-plugin ever gets deleted :-)

@Nikschavan
Copy link
Contributor Author

I was hoping it would be simpler to fork and get this into wp-cli org? I mentioned in the issue #301 it would be preferable to be in this org.

Maybe anyone with capabilities can create a repo here instead and I can use that links in this PR?

@wojsmol
Copy link
Contributor

wojsmol commented Oct 11, 2021

We have https://github.com/wp-cli-test/generic-example-plugin or AFAIK we can transfer @Nikschavan to wp-cli-test organisation.

@Nikschavan
Copy link
Contributor Author

Ahh, I didn't knew about the generic-example-plugin. That should work for this use case as well. I will use that one instead of creating a new one. Thanks @wojsmol :)

Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@Nikschavan
Copy link
Contributor Author

Nikschavan commented Oct 11, 2021

I will need one more help from folks who have access to the repo https://github.com/wp-cli-test/generic-example-plugin.

One of the tests will require a release to be created for the plugin generic-exaple-plugin and a ZIP file to be uploaded to the release, Same as the release on one-time-login plugin - https://github.com/danielbachhuber/one-time-login/releases/tag/v0.1.2

@swissspidy
Copy link
Member

That'd have to be @schlessera in that case

@schlessera
Copy link
Member

@Nikschavan This is done, the repo now has two published releases, each with a separate ZIP as attached asset.

Co-authored-by: Wojciech Smoliński <wojsmol@wp.pl>
@schlessera schlessera added command:plugin-install Related to 'plugin install' command scope:testing Related to testing labels Oct 12, 2021
@schlessera schlessera added this to the 2.1.3 milestone Oct 12, 2021
@schlessera schlessera merged commit 82bdf8b into wp-cli:master Oct 13, 2021
@Nikschavan Nikschavan deleted the 301-php56-tests branch October 13, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:plugin-install Related to 'plugin install' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: failing tests "Branch names should be removed from Github projects" on PHP 5.6

4 participants