Added optional argument --exclude for plugin deactivate#195
Closed
beaucollins wants to merge 4 commits intowp-cli:masterfrom
beaucollins:plugin_deactivate_exclude
Closed
Added optional argument --exclude for plugin deactivate#195beaucollins wants to merge 4 commits intowp-cli:masterfrom beaucollins:plugin_deactivate_exclude
beaucollins wants to merge 4 commits intowp-cli:masterfrom
beaucollins:plugin_deactivate_exclude
Conversation
Contributor
|
Added |
schlessera
requested changes
Sep 27, 2019
| * | ||
| * @param array $args Passed-in arguments. | ||
| * @param bool $all All flag. | ||
| * @param string $exclude Comma separated list of plugin slugs. |
Member
There was a problem hiding this comment.
$verb param seems to be missing here. Not a problem of this PR per se, but makes sense to add it while we're working on this.
Suggested change
| * @param string $exclude Comma separated list of plugin slugs. | |
| * @param string $verb Optional. Verb to use for the messages. Defaults to 'install'. | |
| * @param string $exclude Comma separated list of plugin slugs. |
| */ | ||
| private function check_optional_args_and_all( $args, $all, $verb = 'install' ) { | ||
| private function check_optional_args_and_all( $args, $all, $verb = 'install', $exclude = null ) { | ||
| // Workaround for optional argument $verb |
Member
There was a problem hiding this comment.
This workaround shouldn't be needed, the argument has a default value of 'install' already.
Member
|
The |
Member
|
Thanks for your work on this, @beaucollins ! Closing in favor of #321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #149 onto origin/master on behalf of @achyuthajoy
Added optional argument
--excludeforplugin deactivate --allwhere plugin slugs can be specified as comma-separated.Objective: Allow users to exclude specific plugins from deactivation.
E.g.
wp plugin deactivate --all --exclude=jetpack,akismetAlso, the
--excludeparameter will work only if--allis specified. I've added 2 additional tests to check this feature underfeatures/plugin-deactivate.featureThis is my first contribution to WordPress community. Suggestions and modifications to improve this are appreciated. If this can be achieved with less changes, I'm happy to learn about it as well.
-- @achyuthajoy