WP-CLI Themes: Added workaround to eqalize folder naming conventions across Win/Mac/Linux#151
Closed
achyuthajoy wants to merge 5 commits intowp-cli:masterfrom
Closed
WP-CLI Themes: Added workaround to eqalize folder naming conventions across Win/Mac/Linux#151achyuthajoy wants to merge 5 commits intowp-cli:masterfrom
achyuthajoy wants to merge 5 commits intowp-cli:masterfrom
Conversation
Member
|
@achyuthajoy Can you add Behat tests for this? |
Contributor
Author
Sure @schlessera, will add the tests and update PR. |
Member
|
@achyuthajoy Just let me know if you need help with the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified Theme Fetcher to strict compare specified theme slug against existing ones as a Workaround to Operating System folder naming conventions.
This will equalize the non-lowercase slugs across all operating systems. If exact slug is not found, error is returned.
Fix to #121 - More info added to the bug report