Failed plugin updates now throw errors#143
Merged
schlessera merged 6 commits intowp-cli:masterfrom Dec 12, 2018
Merged
Conversation
schlessera
reviewed
Dec 9, 2018
Co-Authored-By: austinginder <austinginder@gmail.com>
…der/extension-command into fix-90-plugin-update-reporting
schlessera
approved these changes
Dec 11, 2018
schlessera
requested changes
Dec 12, 2018
Co-Authored-By: austinginder <austinginder@gmail.com>
schlessera
approved these changes
Dec 12, 2018
Member
|
Thanks for the PR, @austinginder ! |
This was referenced Dec 12, 2018
Contributor
Author
|
@schlessera Sure thing and thanks for helping me work through the Behat test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve issue #90. This checks for a null response from bulk_upgrade and assumes a plugin update did not occur. That may include more errors than intended as plugin update errors are not included in response. Refer to https://developer.wordpress.org/reference/classes/plugin_upgrader/.