Add --include_once=<section> parameter for before_posts data in multi-file exports
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--include_once=<section> parameter for before_posts data in multifile exports--include_once=<section> parameter for before_posts data in multi-file exports
schlessera
previously requested changes
Dec 8, 2022
Member
schlessera
left a comment
There was a problem hiding this comment.
This looks very good already.
However, the tests are only covering one of the happy paths. Tests should include two more scenarios:
- one where multiple sections are provided via a comma-separated string;
- one where multiple sections are provided in a bad format which triggers the warning.
Member
|
@jmdodd Would you be up for providing the missing test cases, so we can get this over the finish line? |
Member
Author
|
@schlessera I can add the test cases, no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props @jmdodd
Originally #91
Fixes #76