Warn when deleting multisite user with no blog roles by MannyAdumbire · Pull Request #408 · wp-cli/entity-command

MannyAdumbire · 2023-06-04T22:15:44Z

Fixes #403

I have no clue what functional tests should look like for this scenario.
I'm new to Behat and my attempt hangs when doing composer behat -- features/user.feature . Any suggestions?

…-cli#403)

danielbachhuber

I'm new to Behat and my attempt hangs when doing composer behat -- features/user.feature . Any suggestions?

To confirm, you've created a database for the test suite to connect to?

What happens when you run composer behat -- features/user.feature --format pretty?

I have no clue what functional tests should look like for this scenario.

It seems like you made a pretty good start! Do you have some specific questions we could help with?

features/user.feature

danielbachhuber · 2023-06-06T10:25:07Z

src/User_Command.php

 					$result  = wpmu_delete_user( $user_id );
 					$message = "Deleted user {$user_id}.";
+				} else if (is_multisite() && empty($user->roles)) {
+					$message = "No roles found for user {$user_id} on " . get_site_url($blog_id) . ', no users deleted.';


Should we use home_url() like below?

Also, there will be some PHPCS warnings on your current code.

My computer is running php PHP 8.2.4 and I'm getting a single error that prevents phpcs from working properly.
I had to do phpcs --standard=WP_CLI_CS User_Command.php -d error_reporting="E_ALL&~E_DEPRECATED to actaully get accurate( I hope ) report from running phpcs.

MannyAdumbire · 2023-06-07T13:06:02Z

I'm new to Behat and my attempt hangs when doing composer behat -- features/user.feature . Any suggestions?

To confirm, you've created a database for the test suite to connect to?

What happens when you run composer behat -- features/user.feature --format pretty?

Yes, the database setup/install-package-test step all went fine.
Maybe issue was getting hung because of missing --yes?

I've updated the tests with --yes and they now pass.. at least locally :D

MannyAdumbire · 2023-06-07T13:12:07Z

@danielbachhuber I've updated the PR to try and address the issues you pointed out. Thanks for suggestions.

wojsmol · 2023-06-07T13:13:53Z

@MannyAdumbire Yes in Behat tests you must pass --yes because tests are run in non interactive mode.

danielbachhuber · 2023-06-07T18:23:22Z

Maybe issue was getting hung because of missing --yes?

@MannyAdumbire Ah, yeah that will cause the tests to hang.

danielbachhuber

Just one minor nit, then should be good if the tests pass.

danielbachhuber · 2023-06-07T18:28:55Z

features/user.feature

+    And save STDOUT as {BOB_ID}
+
+    When I run `wp user delete bobjones --yes`
+    Then STDOUT should not be empty


Can we use a Then STDOUT should contain:, and also have a And STDERR should be empty?

done!
I was going based off current test
https://github.com/wp-cli/entity-command/blob/1f013e1b097a6af7a1ae85ea797f076486a7c749/features/user.feature#L70-71
but makes sense. hope this works. ;)

MannyAdumbire · 2023-06-08T22:54:27Z

features/user.feature

+    When I run `wp user delete bobjones --yes`
+    Then STDOUT should be:
+      """
+      Success: Removed user {BOB_ID} from https://example.com.


@danielbachhuber Is this Then more specific than necessary? I'm now noticing example that I could have copied

entity-command/features/user.feature

Line 345 in 1f013e1

When I run `wp user delete testsubscriber --yes`

Is this Then more specific than necessary? I'm now noticing example that I could have copied

@MannyAdumbire I don't have strong feelings one way or the other. A little less specific would be fine.

cool! I made it less specific then for consistency with the other step.

MannyAdumbire · 2023-06-08T23:26:23Z

I'm all set as far as changes.
Behat tests passing locally.
Seeing one phpcs error, but I don't think it relates to this PR.

-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 36 | ERROR | Classes declared by a theme/plugin should start with the theme/plugin prefix. Found: "User_Command".
    |       | (WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound)
-------------------------------------------------------------------------------------------------------------------------

danielbachhuber

Great work on this, @MannyAdumbire — thanks again!

Show error message when multisite user to delete has no blog roles(wp…

d0855f8

…-cli#403)

MannyAdumbire requested a review from a team as a code owner June 4, 2023 22:15

MannyAdumbire changed the title ~~Show error when multisite user to delete has no blog roles(#407)~~ Warn when deleting multisite user with no blog roles(#407) Jun 4, 2023

MannyAdumbire changed the title ~~Warn when deleting multisite user with no blog roles(#407)~~ Warn when deleting multisite user with no blog roles(#408) Jun 5, 2023

danielbachhuber reviewed Jun 6, 2023

View reviewed changes

Fix tests and phpcs

43f0420

Replace --yes removed to test

db6ad3f

danielbachhuber reviewed Jun 7, 2023

View reviewed changes

Specify expected output on subsite user delete

ff6af63

MannyAdumbire commented Jun 8, 2023

View reviewed changes

Make subsite user delete test less specific

4fb588a

danielbachhuber changed the title ~~Warn when deleting multisite user with no blog roles(#408)~~ Warn when deleting multisite user with no blog roles Jun 9, 2023

danielbachhuber added command:user Related to 'user' command command:user-delete Related to 'user delete' command labels Jun 9, 2023

danielbachhuber added this to the 2.5.2 milestone Jun 9, 2023

danielbachhuber self-requested a review June 9, 2023 12:25

danielbachhuber approved these changes Jun 9, 2023

View reviewed changes

danielbachhuber merged commit 5c14109 into wp-cli:main Jun 9, 2023

Conversation

MannyAdumbire commented Jun 4, 2023 • edited by danielbachhuber Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielbachhuber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MannyAdumbire commented Jun 7, 2023

Uh oh!

MannyAdumbire commented Jun 7, 2023

Uh oh!

wojsmol commented Jun 7, 2023

Uh oh!

danielbachhuber commented Jun 7, 2023

Uh oh!

danielbachhuber left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MannyAdumbire Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MannyAdumbire commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielbachhuber left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MannyAdumbire commented Jun 4, 2023 •

edited by danielbachhuber

Loading

MannyAdumbire Jun 8, 2023 •

edited

Loading

MannyAdumbire commented Jun 8, 2023 •

edited

Loading